[Ffmpeg-devel] [PATCH] simplify libavformat/allformats.c

[Diego Biurrun]

On Sun, Nov 26, 2006 at 04:14:18PM +0000, M?ns Rullg?rd wrote:
> 
> Aurelien Jacobs said:
> >
> > Currently allformats.c contains more #ifdef lines than actual code.
> > The attached patch highly simplify this. It almost divides by 3 the
> > number of lines in this file.
> > I also took this oportunity to reorder lines alphabetically.
> > Ok to apply ?
> 
> Funny... I was just thinking something along the same lines.  I have
> two comments:
> 
> - The reordering should be a separate patch.
> - I'm not sure what I think of the combined muxer/demuxer lines.
>   It saves a few lines, but having them separate keeps things
>   clearer IMHO.

Patch looks good to me, getting rid of this #ifdef jungle is a good
idea.  I don't think the combined lines are a big problem, but i don't
have a strong opinion.  I do tend to prefer more compact code, though.

Diego