[Ffmpeg-devel] [PATCH] allow full FLAC metadata in the extradata

Michael Niedermayer michaelni
Thu Nov 23 20:03:43 CET 2006


Hi

On Wed, Nov 22, 2006 at 07:54:55PM +0100, Aurelien Jacobs wrote:
> Hi,
> 
> This patch allows to pass a full FLAC metadata packet in the extradata.
> That's the way flac is stored in matroska.

looks ok except


[...]
>  
> +static int metadata_parse(FLACContext *s)

this one should have a doxygen comment at least explaining what the function
does and what the return value means


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is




More information about the ffmpeg-devel mailing list