[Ffmpeg-devel] [PATCH] put_mpeg4_qpel16_h_lowpass altivec implementation

Brian Foley bfoley
Mon Nov 20 02:07:44 CET 2006


On Mon, Nov 20, 2006 at 01:01:37AM +0100, Guillaume POIRIER wrote:
> Tested on OSX 10.4.x, with apple's gcc4.0.1
> Works beautifully. Thanks for the good job.

Thanks.
 
> I've just tested it with gcc3.4 on Linux, and here's the error that gcc 
> reports:

Interesting. I can't reproduce this with Apple's compiler and
unfortunately I don't have a Linux/PPC box to hand. I'll try putting
together a small Debian/PPC install under gxemul/qemu so I can test
patches before sumbitting them in future, but I won't be able to do
that for a day or two.

Are there any particular compiler versions with annoying quirks that I
should look out for when doing this? GCC 3.4, by the looks of things,
but anything else?

> It would be good if you could fix this. If you can't then I'll fix it 
> before committing.

If you could, that'd be great. Please be careful though. Changing
the types can change the exact Altivec instruction the compiler
generates, and I've broken this code more than once by messing around
with the type casting.

> Well, there's also some work to do on h264 decoding too... there's 
> plenty of things to do, I doubt we will step on each other's toes ;-P

Excellent. I'm looking forward to be able to play h264 on a Mac Cube :)

Cheers,
Brian.




More information about the ffmpeg-devel mailing list