[Ffmpeg-devel] GET/PUT_UTF8 misleading/wrong comment

Michael Niedermayer michaelni
Sat Nov 18 15:45:37 CET 2006


Hi

On Sat, Nov 18, 2006 at 12:13:30PM +0100, Reimar D?ffinger wrote:
> Hello,
> The comments say about the GET_BYTE/PUT_BYTE parameters:
> "It will be execuded up to 4 times."
> or
> "PUT_BYTE will be executed up to 4 times".
> While this may be right with valid UTF8, there is nothing at all in the
> code to ensure this.
> How should this be fixed?
> Either replace 4 by 7, and maybe add that for valid UTF8 it will be 4 at

yes

utf8 is (mis)used by flac so limiting to 4 could be problematic

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is




More information about the ffmpeg-devel mailing list