[Ffmpeg-devel] [PATCH] get rid of CODEC_ID_MPEG4AAC after next major version bump

[Michael Niedermayer]

Hi

On Thu, Nov 09, 2006 at 03:28:15AM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > Hi
> >
> > On Thu, Nov 09, 2006 at 12:22:11AM +0000, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> 
> >> > Hi
> >> >
> >> > On Thu, Nov 09, 2006 at 12:23:10AM +0100, Baptiste Coudurier wrote:
> >> > [...]
> >> >> Index: libavformat/avidec.c
> >> >> ===================================================================
> >> >> --- libavformat/avidec.c	(revision 6947)
> >> >> +++ libavformat/avidec.c	(working copy)
> >> >> @@ -443,6 +443,8 @@
> >> >>                      /* special case time: To support Xan DPCM, hardcode
> >> >>                       * the format if Xxan is the video codec */
> >> >>                      st->need_parsing = 1;
> >> >> +                    if (st->codec->codec_id == CODEC_ID_AAC && st->codec->extradata_size)
> >> >> +                        st->need_parsing = 0; /* do not parse since header is in extradata */
> >> >
> >> > why? what bad happens if st->need_parsing = 1 ?
> >> 
> >> The parser fails.
> >
> > do you know why?
> 
> The parser requires ADTS frame headers, which are not present in this
> case.  That is not a problem, since AAC without these headers must be
> stored as exact frames by the container anyway.

thanks for clarifying, in that case the patch is ok though mans explanation
should be added as a comment to the st->need_parsing = 0 case

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is