[Ffmpeg-devel] decode_init_vlc in h264.c

[Michael Niedermayer]

Hi

On Wed, Nov 08, 2006 at 04:07:50PM +0100, Panagiotis Issaris wrote:
> Hi,
> 
> The function decode_init_vlc() takes a H264Context as a parameter
> although it does not use it:
> 
> 3152 static void decode_init_vlc(H264Context *h){
> ...
> 3159         init_vlc(&chroma_dc_coeff_token_vlc,
> CHROMA_DC_COEFF_TOKEN_VLC_BITS, 4*5,
> 3160                  &chroma_dc_coeff_token_len [0], 1, 1,
> 3161                  &chroma_dc_coeff_token_bits[0], 1, 1, 1);
> 
> ...
> }
> The only variables being accessed are static globals.
> 
> Should the h parameter go away?

if its unused, yes why not ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is