[Ffmpeg-devel] [PATCH] compile with demux only

Michael Niedermayer michaelni
Wed Nov 8 02:26:55 CET 2006


Hi

On Tue, Nov 07, 2006 at 06:02:37PM +0100, Loic wrote:

[stuff not maintained by me]

> 
> ff_cavs_find_frame_end function which is in cavs.c has been moved to
> parser.c in the same block where it is used. As this function is only
> used here, it can be removed for parser.h and declared static.
> Note that some defines from cavsdata.h are needed by
> ff_cavs_find_frame_end so I put them in a separate cavs.h file and
> include it from cavs.c and parser.c (I don't include cavsdata.h directly
> in parser.c because it contains many static const variable declaration
> which use memory but wont be used).

while i have no strong oppinion about this IMHO the cavs parser code should
rather stay in cavs.c or be put in a seperate file alltogether, parser.c
does not seem like the best place
but iam not maintainer of cavs either ...


> 
> Hope this patch can be included.

i hope you can split it into independant parts :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is




More information about the ffmpeg-devel mailing list