[Ffmpeg-devel] [PATCH] MS-GSM support: draft for review

[Michael Niedermayer]

Hi

On Tue, Nov 07, 2006 at 04:47:52PM +0100, Michel Bardiaux wrote:
[...]
> >
> >
> >>And I think the time needed to write one could be 
> >>better spent on something else that people actually use.
> >>
> >>And with regard of bitstream filters, I've heard lots of talk about it 
> >>but no actual info on how to write one. Can you show some code/info 
> >>about it?
> >
> >see libavcodec/bitstream_filter.c
> >
> >there are also some example filters in there
> >
> Now I'm lost again.
> 
> 1. Decoder: with a parser, or a bitstream filter?
> 
> 2. Encoder: you said bitstream_filter, right? Problem is, it seems one 
> has to call av_bitstream_filter_filter oneself before av_write_frame.
> 
> 3. Both: since we go back to one codec, how are we going to tell the 
> parser when it has to handle frames of 33, or 32 1/2? Maybe the right 
> place to put this stuff is after all wav_read_packet. What do you think?

codec_tag could be used ... but this is getting more messy then i hoped,
i thought we just have to split packets up / merge them :(((

so after reconsidering all that mess, lets go back to your patch
IMHO the formats are sufficiently different to have individual codec_ids
bitstream filters to convert still would be welcome of course

could you resubmit your patch without ANY renamings and cosmetics?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is