[Ffmpeg-devel] PUT_UTF8 & asf format enhancement

Zuxy Meng zuxy.meng
Sun Nov 5 10:14:32 CET 2006


Hi,

2006/11/5, Diego Biurrun <diego at biurrun.de>:
> On Sun, Nov 05, 2006 at 04:56:13PM +0800, Zuxy Meng wrote:
> >
> > 1. Add a PUT_UTF8 macro to common.h; code borrowed from
> > libavcodec/flacenc.c.
>
> Code duplication is generally not acceptable, but I cannot find that
> macro in libavcodec/flacenc.c ...

It's in write_utf8(). Once previous patches get applied it can
replaced by PUT_UTF8 too and hence code duplication is avoided.

BTW: I was suggested by Reimar to learn from flacenc.c and avoid an
iconv dependency:-)

-- 
Zuxy
Beauty is truth,
While truth is beauty.
PGP KeyID: E8555ED6




More information about the ffmpeg-devel mailing list