[Ffmpeg-devel] [patch] ifdef dv in avi container

[Aurelien Jacobs]

On Wed, 01 Nov 2006 16:26:14 -0800
Tom Harper <d.thomas.harper at gmail.com> wrote:

> Hi,
> 
> This patch allows the use of avi decoding without dv enabled.
> Maybe there is some prettier way to do this, but as is this helps
> reduce code size a bit if dv is not required.

I agree there is some prettier way to do this. Let's see the attached
patch.
Note that the #define ENABLE_DVVIDEO_DECODER should be done in
config.h instead of the top of avidec.c, but this belong to another
patch (that I will provide if the idea is accepted).

With this method, this is the compiler which optimize out the
relevant sections of code, instead of removing them with the
preprocessor.
The final effect is quite the same: the DV code sections are not
part of the object file if DV is not enabled.

Advantages of this way to do things:
 - smaller diff
 - smaller source code
 - less ugly #ifdef mess
 - the compiler can still parse and check for errors in the
   DV only sections before optimizing them out

Aurel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: avi-no-dv.diff
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061102/29c69c94/attachment.asc>