[Ffmpeg-devel] Re: [RFC] mpeg2 422 encoding.

[Baptiste Coudurier]

Hi

Michael Niedermayer wrote:
> [...]
> 
> faster too (amd duron 800mhz), no clue why either ...
> 
> patch ok, a few minor cosmetical ideas below though (can be ignored or
> commited later)
> 

Great !

> [...]
> 
> if(s->chroma_format == CHROMA_422)
>     avctx->profile = 0;
> else
>     avctx->profile = 4;
> 
> is half the number of lines ...
> 
>     chroma_format2profile[4]={4,4,0,4};
>     avctx->profile= chroma_format2profile[s->chroma_format]
> 
> is a quarter though maybe less readable
> 

Did even simpler.

> [...]
> 
> put_bits1(&s->pb, s->chroma_format != CHROMA_420); //escx
> 

Done.

> [...]
> 

Applied ! Great news.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312