[Ffmpeg-devel] [BUG] vorbis decoder

[Loren Merritt]

On Wed, 10 May 2006, Mike Melanson wrote:
> Benjamin Larsson wrote:
>> Benjamin Larsson wrote:
>> 
>>> This file seams to segfault the vorbis decoder.
>>> 
>>> http://www.vorbis.com/music/Lumme-Badloop.ogg
>>> 
>>> MvH
>>> Benjamin Larsson
>> 
>> Loren fixed it.
>
> With this fix?
>
> - floor_setup->data.t1.subclass_books[j][k]=get_bits(gb, 8)-1;
> + floor_setup->data.t1.subclass_books[j][k]=(int16_t)get_bits(gb, 8)-1;
>
> I would just like to point out that I can't understand (big surprise there) 
> why this change makes a difference.

get_bits returns (unsigned int)
subclass_books[][] is int_fast16_t
int_fast16_t is 64bits on x86_64
so -1 fails to be negative

--Loren Merritt