[Ffmpeg-devel] [PATCH] cygwin, link error

[Måns Rullgård]

Diego Biurrun said:
> On Tue, Mar 21, 2006 at 01:15:50PM +0100, Marcus Engene wrote:
>>
>> ffmpeg cvs today, cygwin updated today.
>>
>> Perhaps I've done something silly again.
>> Compilation gets upset that libz isn't after the things using it.
>>
>> Attached patch on libavformat/Makefile
>> fixes the compilation. Is it ok?
>
> I just confirmed the problem and the fix.

Yep, there's a problem alright.

>> --- Makefile.org	2006-03-21 14:02:07.343750000 +0100
>> +++ Makefile	2006-03-21 14:02:27.343750000 +0100
>> @@ -66,7 +66,7 @@
>>  OBJS+= audio.o
>>  endif
>>
>> -EXTRALIBS += -L../libavutil -lavutil$(BUILDSUF) -lavcodec$(BUILDSUF)
>> -L../libavcodec
>> +EXTRALIBS := -L../libavutil -lavutil$(BUILDSUF) -lavcodec$(BUILDSUF)
>> -L../libavcodec $(EXTRALIBS)
>
> I don't particularly like it, but I don't know a better solution.  Mans?

The only other solution I can think of is to split EXTRALIBS into two
variables, one that is set only from configure and one that is set in
the makefiles.  I'm not convinced this is much cleaner though.  Do as
you see fit, you're the makefile maintainer.

-- 
M?ns Rullg?rd
mru at inprovide.com