[Ffmpeg-devel] Re: [PATCH] MinGW and portability

[Michael Niedermayer]

Hi

On Wed, Mar 29, 2006 at 10:14:46AM +0200, Frantisek Dvorak wrote:
[...]
> >> Index: qt-faststart.c
> >> ===================================================================
> >> RCS file: /cvsroot/ffmpeg/ffmpeg/qt-faststart.c,v
> >> retrieving revision 1.8
> >> diff -u -p -u -r1.8 qt-faststart.c
> >> --- qt-faststart.c	27 Mar 2006 16:34:21 -0000	1.8
> >> +++ qt-faststart.c	28 Mar 2006 18:02:39 -0000
> >> @@ -20,13 +20,24 @@
> >>   * presently only operates on uncompressed moov atoms.
> >>   */
> >>  
> >> +#include "config.h"
> >>  #include <stdio.h>
> >>  #include <stdlib.h>
> >> +#ifdef HAVE_INTTYPES_H
> >>  #include <inttypes.h>
> >> +#endif
> >> +#ifdef HAVE_STDINT_H
> >> +#include <stdint.h>
> >> +#endif
> >
> > Both inttypes.h and stdint.h are standard C.  If you are missing them
> > you should fix your environment.
> >
> 
> Standard C? I agree good environments should have it, but there already
> are some check for inttypes.h in configure to make ffmpeg as portable as
> possible.

the fix is to provide a inttypes.h if we really have to support this
not to hack every file which includes it (though IMO supporting old versions
of buggy tools isnt a good idea)


[...] 

-- 
Michael