[Ffmpeg-devel] [PATCH] mingw and temorary files

[Måns Rullgård]

Corey Hickey <bugfood-ml at fatooh.org> writes:

> Michael Niedermayer wrote:
>>>>>>>>>>>  +int av_tempfile(char *prefix, char **filename);
>>>>>>>>>>> +
>>>>>>>>>> avcodec.h is a public header, IMHO this isnt the correct spot for it
>>>>>>>>> I was wondering about that, but then I thought it could theoretically
>>>>>>>>> be useful to a calling program. I don't know anything about such
>>>>>>>>> stuff, though, so I definitely don't mind putting the prototype
>>>>>>>>> somewhere else if you prefer. Which header file should I use? I don't
>>>>>>>>> know where things like that go.
>>>>>>>> It certainly shouldn't go in avcodec.h, since it has nothing to do
>>>>>>>> with codecs.  I'd say such things belong in libavutil and it's header
>>>>>>>> files.
>>>>>>> i disagree, libavutil should stay small, and this is a almost
>>>>>>> useless function for the end user ...
>>>>>> Remind me what the purpose of libavutil is.
>>>>> IMHO a small lib of usefull av related things
>>>>> code which is common to lavc & lavf can be put into lavc as lavf depends
>>>>> on lavc anyway
>>>> So, then, what should I do? ls *.h doesn't show me any header file that
>> i dont know either :)
>
> :))
>
> Ok, well, since there doesn't seem to any reasonable existing file,
> this patch makes one and sticks the prototype there.
>
> Does anyone object? If not, I'll apply it in two days. ...or sooner,
> if I get the go-ahead.
>
> -Corey
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/Makefile,v
> retrieving revision 1.247
> diff -u -r1.247 Makefile
> --- Makefile	21 Mar 2006 17:27:46 -0000	1.247
> +++ Makefile	26 Mar 2006 23:22:07 -0000
> @@ -18,7 +18,7 @@
>        vp3dsp.o h264idct.o rangecoder.o pnm.o h263.o msmpeg4.o h263dec.o \
>        opt.o
>
> -HEADERS = avcodec.h
> +HEADERS = avcodec.h internal.h

Don't install it.

-- 
M?ns Rullg?rd
mru at inprovide.com