[Ffmpeg-devel] Re: [PATCH] mov pcm sample count fix

[Baptiste COUDURIER]

Hi

Michael Niedermayer wrote:
> [...]
> without any check there might be access after the end of the array
> 
> and (in current cvs)
> 
> dts = sc->sample_to_time_time + (sc->current_sample-1 - sc->sample_to_time_sample) * (int64_t)duration;
> 
> 
> sc->current_sample-1 is wrong, as there might be more then 1 sample in a
> packet, so it seems whoever wrote this couldnz decide if current_sample
> was the current or next sample
> 
> maybe the attached patch fixes the issue?
> ill commit mine unless you say it breaks demuxing of on of your files
> 
> [...]
> 

Yeah it does great. Commit it.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312