[Ffmpeg-devel] [PATCH] snow mmx + sse2 part 3

[Guillaume POIRIER]

Hi,

On 3/20/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> Hi
>
> On Mon, Mar 20, 2006 at 08:47:48PM +0200, Oded Shimon wrote:
> > On Mon, Mar 20, 2006 at 11:54:18AM -0500, Robert Edele wrote:
> > > Here's part three of my snow asm patch, which covers the mmx and sse2
> > > implementations of ff_snow_vertical_compose().
> >
> > You might as well send all your mmx, a patch is only seperable when the
> > different parts really cover different things or are logical as seperate.
> > this might as well be just a single patch.
> >
> > > Index: libavcodec/i386/dsputil_mmx.c
> > > ===================================================================
> > > RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/i386/dsputil_mmx.c,v
> > > retrieving revision 1.113
> > > diff -u -r1.113 dsputil_mmx.c
> > > --- libavcodec/i386/dsputil_mmx.c   7 Mar 2006 22:45:56 -0000       1.113
> > > +++ libavcodec/i386/dsputil_mmx.c   20 Mar 2006 16:45:48 -0000
> > > @@ -2564,6 +2564,9 @@
> > >  }
> > >  #endif
> > >
> > > +extern void ff_snow_vertical_compose97i_sse2(DWTELEM *b0, DWTELEM *b1, DWTELEM *b2, DWTELEM *b3, DWTELEM *b4, DWTELEM *b5, int width);
> > > +extern void ff_snow_vertical_compose97i_mmx(DWTELEM *b0, DWTELEM *b1, DWTELEM *b2, DWTELEM *b3, DWTELEM *b4, DWTELEM *b5, int width);
> >
> > I still HIGHLY dislike these declerations. A much better approach would be
> > to either use static functions and #include the .c file directly, or to use
> > some common header. I preffer the former as an added bonus there is no
> > (additional) namespace bloat.
>
> iam against #including the c file, dsputil_mmx.c is large enough
>
> and patch looks ok

Tested on both AMD-64 and i386, it works as expected.

Committed! (along with some whitespace that I removed to meet the CVS policy).

Let's hope I didn't break anything this time! :)

Guillaume
--
I am disillusioned enough to know that no man's opinion on any subject
is worth a damn unless backed up with enough genuine information to
make him really know what he's talking about.

-- H. P. Lovecraft (about the flamewars on FFmpeg and MPlayer-dev mailing lists)
http://www.brainyquote.com/quotes/quotes/h/hplovecr278144.html