[Ffmpeg-devel] Build failure if snow is disabled

[Oded Shimon]

On Fri, Mar 17, 2006 at 12:30:41PM +0100, Luca Abeni wrote:
> Hi all,
> 
> if I configure with
> ./configure --disable-decoder=snow --disable-encoder=snow
> I get
> [...]
> gcc -Wl,--warn-common -rdynamic -g -o ffmpeg_g ffmpeg.o cmdutils.o -L./libavformat -lavformat -L./libavcodec -lavcodec -L./libavutil -lavutil -lm -lz -ldl
> ./libavcodec/libavcodec.a(dsputil.o): In function `dsputil_init':/tmp/ffmpeg/libavcodec/dsputil.c:4052: undefined reference to `ff_snow_horizontal_compose97i'
> :/tmp/ffmpeg/libavcodec/dsputil.c:4053: undefined reference to `ff_snow_inner_add_yblock'
> :/tmp/ffmpeg/libavcodec/dsputil.c:4051: undefined reference to `ff_snow_vertical_compose97i'
> collect2: ld returned 1 exit status
> make: *** [ffmpeg_g] Error 1
> 
> I do not know what's the best way to fix this bug. It seems that all the
> other codecs address this issue by still compiling some code even if
> they are disabled (for example, if I do "--disable-decoder=h264
> --disable-encoder=h264", h264idct.c is still compiled).
> This increases the library size a lot... :(

Guillaume, here's that 18 wheeler you wanted. Fault goes to me (and you :). 
I remember noticing this a while ago, I completely forgot to fix it though.

- ods15
-------------- next part --------------
Index: libavcodec/dsputil.c
===================================================================
RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/dsputil.c,v
retrieving revision 1.135
diff -u -r1.135 dsputil.c
--- libavcodec/dsputil.c	16 Mar 2006 19:18:17 -0000	1.135
+++ libavcodec/dsputil.c	17 Mar 2006 11:33:33 -0000
@@ -4048,9 +4048,11 @@
     c->try_8x8basis= try_8x8basis_c;
     c->add_8x8basis= add_8x8basis_c;
 
+#ifdef CONFIG_SNOW_ENCODER
     c->vertical_compose97i = ff_snow_vertical_compose97i;
     c->horizontal_compose97i = ff_snow_horizontal_compose97i;
     c->inner_add_yblock = ff_snow_inner_add_yblock;
+#endif
 
 #ifdef HAVE_MMX
     dsputil_init_mmx(c, avctx);