[Ffmpeg-devel] [PATCH] Snow mmx+sse2 asm optimizations

Michael Niedermayer michaelni
Mon Mar 13 02:52:26 CET 2006


On Sun, Mar 12, 2006 at 04:39:49PM -0500, Robert Edele wrote:
> On Sat, 2006-03-11 at 14:37 +0100, Michael Niedermayer wrote:
> > 
> > patch permanently rejected i will not review it again, find someone else, its
> > too much work to review it over and over again just to find the same issues
> > 
> > Note, to whoever reviews it, check if all the issue raised in past replies
> > have been fixed
> > 
> As far as that previous bug goes, I accidentally posted an old patch.
> I'm sorry and I do understand that reviewing patches is very time
> consuming.
> I've split the patch into pieces (at least 5), the first of which
> contains no asm. Would you mind forgiving me and having a look at the
> first piece, which sets up a snow.h and makes snow use the dsputil
> function pointer framework to access the three functions that are
> implemented in asm in the other parts of the patch.

ok, first patch looks mostly ok, iam not particulary happy about the
inclusion of snow.h in dsputil.h but i dont really care
as dsputil.h was never supposed to be a public header, so whoever
came up with that idea can fix the snow.h inclusion (installing snow.h
along with avcodec.h is not ok)



More information about the ffmpeg-devel mailing list