[Ffmpeg-devel] [PATCH] Snow mmx+sse2 asm optimizations

[Michael Niedermayer]

Hi

On Fri, Mar 10, 2006 at 09:07:44PM -0500, Robert Edele wrote:
> On Sat, 2006-03-11 at 01:50 +0100, Michael Niedermayer wrote:
> > > +             "add $"PTR_SIZE"*1, %1          \n\t"\
> > > +             "add %%"REG_c", %0              \n\t"\
> > > +             "dec %%"REG_b"                  \n\t"\
> > > +             "jnz 1b                         \n\t"\
> > > +             :\
> > > +             :\
> > > +             "m"(dst8),"m"(dst_array),"rm"((long)(src_x<<2)),"m"(obmc),"a"(block),"m"((long)b_h),"rm"((long)src_stride):\
> > > +             "%"REG_b"","%"REG_c"","%"REG_S"","%"REG_D"","%"REG_d"");
> > 
> > %0 and %1 are changed but on the input list
> > 
> Fixed. Updated patch attached.
> 
> Robert Edele

[...]
> +             "add $"PTR_SIZE"*1, %1          \n\t"\
> +             "add %%"REG_c", %0              \n\t"\
> +             "dec %%"REG_b"                  \n\t"\
> +             "jnz 1b                         \n\t"\
> +             :\
> +             :\
> +             "m"(dst8),"m"(dst_array),"rm"((long)(src_x<<2)),"m"(obmc),"a"(block),"m"((long)b_h),"rm"((long)src_stride):\
> +             "%"REG_b"","%"REG_c"","%"REG_S"","%"REG_D"","%"REG_d"");
[...]

patch permanently rejected i will not review it again, find someone else, its
too much work to review it over and over again just to find the same issues

Note, to whoever reviews it, check if all the issue raised in past replies
have been fixed

-- 
Michael