[Ffmpeg-devel] Re: [PATCH] DVCPRO50 support

[Roman Shaposhnik]

On Mon, Mar 06, 2006 at 11:11:55AM +0100, Diego Biurrun wrote:
> On Mon, Mar 06, 2006 at 01:32:47AM -0800, Roman Shaposhnick wrote:
> > 
> > it's applied. There's still a small glitch w.r.t. container formats not
> > setting pix_fmt correctly for decoder and a couple of other small things
> > I would like to tweak during the week. But otherwise -- it went into
> > a CVS pretty much unchanged. 
> 
> Could you please add this to the changelog, it appears to be worth
> noting..

  Will do.

> > P.S. The main trick was to review your changes with 'diff -b'
> > which cuts down 80% of the indentation related changes ;-)
> 
> Or make him send in patches created with diff -ub ;)
  
  The situation with Dan's patch was an interesting one -- he had to add
  a couple of external if statements to an already existing chunks of code
  and because we all love and cherish proper indentation -- it also had
  to be done. All of the above presents a reviewer with a need to somehow
  filter out all the unchanged (but indented!) code yet to apply the original
  patch in order to preserve proper indentation. Once I realized that
  doing diff -ub does that filtering for me the review process got much
  quicker ;-)

Thanks,
Roman.