flaming (was: Re: [Ffmpeg-devel] [PATCH] near is a special keyword)

Rich Felker dalias
Thu Mar 2 06:47:39 CET 2006


On Thu, Mar 02, 2006 at 01:36:33AM +0100, Diego Biurrun wrote:
> @all: Steve is just trying to share his code here, his effort should be
> appreciated, don't forget that we don't have an abundance of proprietary
> software vendors that try to cooperate with us.

I understand this sentiment, but there's a proper attitude for
everything. "You should 'fix your code' with this patch." is not a
proper attitude when the problem is in the calling code written by the
person sending the patch.

I'm sorry for getting you down with flames Diego. I just don't have
much patience for windows users who want software projects to put
windows-specific workarounds in their code. I have a principle of
hacks and workarounds that I often like to cite for MPlayer and it's
valid here too: Whenever there's a broken component that requires some
sort of special casing, the hacks to support it belong as close as
possible to the offending component. In no case should they
contaminate the general code. -Dnear=windows_sucks_near in the windows
build config versus renaming a variable in the general code is a
perfect example.

Rich





More information about the ffmpeg-devel mailing list