[Ffmpeg-devel] [PATCH] Merge some changes from xine-lib's ffmpeg patch
Fri Jun 30 00:01:19 CEST 2006
On Thu, Jun 29, 2006 at 03:00:37PM +0200, Diego 'Flameeyes' Petten? wrote:
> On Thursday 29 June 2006 03:09, Michael Niedermayer wrote:
> > our code is buggy in some sense in that case, your patch doesnt fix it
> > but just hides a warning which points to that buggy code ... this isnt
> > the correct way to handle bugs or?
> Okay, so I looked more deeply into the code, the function that was removed
> (w_c) requires dwt that is defined in snow.c and thus it is available only on
> CONFIG_SNOW_ENCODER enabled.
> Removing w_c from the code requires either removing or dummifying the
> functions w53_8_c, w97_8_c, w53_16_c, w97_16_c, w53_32_c and w97_32_c, some
> of which are used to fill DSPContext::w53 and DSPContext::w97 attributes. The
> only functions called directly of those seems to be w53_32_c and w97_32_c in
> snow.c, while w32 and w97 are used as AVOptions.
> So I'm attaching the new patch that removes all those functions when the snow
> encoded is not built, plus it removes the misssing initialisations warning
> that seems to be harmless and tries to clarify the point of setting the
> header's attributes (either that or their usage should be dropped until
> FLAG_SPRITE is correctly handled).
are the changes related?
fix wrong code (no return)
add code to detect wrong printf format
suppress a redefiend warning
one issue one patch -> split them please
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is
More information about the ffmpeg-devel