[Ffmpeg-devel] [PATCH] Add allformats.h include file to move *_init() functions and other

[Måns Rullgård]

Steve Lhomme <slhomme at divxcorp.com> writes:

> Rich Felker wrote:
>> On Thu, Jun 29, 2006 at 07:19:30PM +0200, Diego 'Flameeyes' Petten? wrote:
>>> On Thursday 29 June 2006 19:06, Rich Felker wrote:
>>>> because it's part of the c++monkey mindset to add it to every header
>>>> file...
>>> Most likely because I simply put it when I'm not sure if the code
>>> ends up being standalone or what. FFmpeg is currently being
>>> used/imported by other projects, and "better safe than sorry" is my
>>> usual line here (especially considering it's being used by
>>> wengophone that uses scons, which I don't trust for correctly
>>> separate C and C++ code for instance).
>> extern "C" { } does not even belong in headers to be used by the
>> caller. instead, c++ apps should put their own extern "C" {} around
>> includes for C-language headers. libavcodec is written in C, not C++,
>> and extern "C" {} is not part of C.
>
> Is there a C compiler that fails on extern "C" ? At least among the
> one(s) supported by FFMPEG.

Only all of them.

-- 
M?ns Rullg?rd
mru at inprovide.com