[Ffmpeg-devel] [PATCH] Merge some changes from xine-lib's ffmpeg patch

[Diego 'Flameeyes' Pettenò]

On Thursday 29 June 2006 01:41, Michael Niedermayer wrote:
> this is silly, the whole function shouldnt be compiled if it cant be, not
> just returning a incorrect value ...
I'm not really sure why the condition on that function is put that way, but as 
it is, it returns a random value, so.. it's surely not 100% right that way 
either.

> > +    /* These are not used a part from in the FLAG_SPRITE part, but that
> > seems +       not to be complete anyway */
> > +    header.width = 0;
> > +    header.height = 0;
> > +    header.xoffset = 0;
> > +    header.yoffset = 0;
> is the comment supposed to make sense?
supposed, yes, maybe a bit confused, and my Engrish is always bad :?
Basically those four attributes of the struct are used as source to setting 
other variables in the if () entry for FLAG_SPRITE... considering that they 
were not initialised before, it means there's something incomplete there.

> > +    NULL, NULL, NULL, NULL
> rejected, this change is random, inconsistent and unneeded
Uhm, it's not random. It adds the initialisation of the structure members, or 
they would be uninitialised (as in, random content). GCC 4 issues a warning 
about it. This actually it's not in xine-lib's patch, but I hit it by chance 
and fixed locally, I should have moved it on its own patch, most likely.

> > -#    ifndef DEBUG
> > +#    if !defined(DEBUG) && !defined(NDEBUG)
> >  #        define NDEBUG
> >  #    endif
> >  #    include <assert.h>
> what is the purpose of this change?
Avoids redefinition of NDEBUG if it's already defined.

-- 
Diego "Flameeyes" Petten? - http://farragut.flameeyes.is-a-geek.org/
Gentoo/Alt lead, Gentoo/FreeBSD, Video, AMD64, Sound, PAM, KDE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060629/c0eb2192/attachment.pgp>