[Ffmpeg-devel] [PATCH] Chinese AVS video decoder

[Benjamin Larsson]

Stefan Gehrer wrote:

>Benjamin Larsson wrote:
>  
>
>>Stefan Gehrer wrote:
>>
>>    
>>
>>>Hi list,
>>>
>>>attached is my decoder for the Chinese AVS video standard, adapted for
>>>lavc inclusion.
>>>
>>>      
>>>
>>[...]
>>
>>Hi, I tried the patch on a amd64 box and got this error:
>>    
>>
>
>Thanks for testing. I hope to hear from someone that it does work on
>a 32bit machine other than mine, then I will see how I can get access
>to an amd64 box. If I can't, can I molest you with some debugging tasks
>for this?
>  
>
Sure.

>
>  
>
>>And the indentation is 4 spaces and there are some trailing spaces in the
>>patch.
>>    
>>
>
>Isn't it supposed to be indentation of four?
>  
>
Disregard that, the editor that I was using to look at the patch is
broken. (Note to self, never trust windows tools again.)

>The thing with the trailing whitespaces is really strange: I can see them when I look at the patch with my hexeditor, but at the corresponding places
>in the source they are not there. Yet after doing
>
>svn diff > cavsdiff
>
>or even
>
>svn diff | ./clean-diff > cavsdiff
>
>they are there.
>I guess I have to go manually through the next version of the patch then.
>
>Regards
>Stefan Gehrer
>  
>
And the comments should be doxygen comments. I saw some char use that
maybe should be int8_t of fast_int8_t for consistency ?

MvH
Benjamin Larsson

-- 
"incorrect information" is an oxymoron. Information is, by definition, factual, correct.