[Ffmpeg-devel] Re: [MPlayer-dev-eng] [PATCH] fix --with-x264incdir ignored in libavcodec/Makefile

[Måns Rullgård]

M?ns Rullg?rd <mru at inprovide.com> writes:

> Guillaume Poirier said:
>> Hi,
>>
>> Vladislav Naumov wrote:
>>> I don't know - maybe it should be posted to libavcodec developers...
>>>
>>> If x264 includes are specified with --with-x264incdir,
>>> libavcodec/Makefile ignores it.
>>>
>>> Here you are - a mini-patch.
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> Index: libavcodec/Makefile
>>> ===================================================================
>>> --- libavcodec/Makefile	(revision 5501)
>>> +++ libavcodec/Makefile	(working copy)
>>> @@ -318,6 +318,7 @@
>>>
>>>  ifeq ($(CONFIG_X264),yes)
>>>  OBJS+= x264.o
>>> +CFLAGS += $(X264_INC)
>>>  endif
>>>
>>>  ifeq ($(CONFIG_MP3LAME),yes)
>>>
>>>
>>> ------------------------------------------------------------------------
>>
>> I had the same patch on my tree. I'll apply it unless someone (Diego?)
>> disagrees.
>
> This is the wrong fix.  It should be done in configure instead.  I'll look
> into it tonight.

Actually, this is the wrong list.  FFmpeg configure has no
--with-x264incdir option, and thus can't possibly be expected to act
on it.  If mplayer configure wants to have such an option, it is also
responsible for setting CFLAGS as needed for the ffmpeg build.
Besides, x264 installs headers and libs just like any well-behaved
package these days.  I'm guessing that option was added back in the
days when x264 didn't have a "make install" target and should now be
considered obsolete.

Diego, this is your job, even you refuse to be one of my minions.

-- 
M?ns Rullg?rd
mru at inprovide.com