[Ffmpeg-devel] [PATCH] 24-bits flac support (with 16-bits output)

Luca Barbato lu_zero
Wed Jun 21 15:30:58 CEST 2006


Dave Chapman wrote:
> Luca Barbato wrote:
>> Dave Chapman wrote:
>>
>>> i.e. it might be more efficient to have an if statement to choose
>>> between two loops - one performing 32x32->32 and one performing
>>> 32x32->64, depending on the precision required.
>>>
>>
>> feel free to try this patch, if nobody complains I'll add it.
>>
> 
> I'm assuming this means that for some frames of > 16-bit samples, it's
> possible to use the 32-bit version of the loop without fear of overflow
> - further optimising for CPUs where the 32x32->64 multiplication is
> expensive.

The patch got committed with an unoptimized check then, could you check
with samples how much we lose?

lu

-- 

Luca Barbato

Gentoo/linux Gentoo/PPC
http://dev.gentoo.org/~lu_zero





More information about the ffmpeg-devel mailing list