[Ffmpeg-devel] About swscale

[Luca Abeni]

Hi Diego,

On Wed, 2006-06-21 at 14:06 +0200, Diego Biurrun wrote:
[...]
> > > --- main.orig/configure	2006-05-19 07:41:28.000000000 +0200
> > > +++ main/configure	2006-05-19 11:09:59.000000000 +0200
> > > @@ -7343,6 +7343,30 @@
> > >  fi
> > >  echores "$_lircc"
> > >  
> > > +echocheck "Software Scaler"
> > > +_swscaler=no
> > > +cat > $TMPC <<EOF
> > > +#include <stdint.h>
> > > +#include "libswscale/swscale.h"
> > > +int main(void) { return 0; }
> > > +EOF
> > > +cc_check -I . && _swscaler=yes
> > > +echores "$_swscaler"
> > > +if test "$_swscaler" = no ; then
> > > +die "Software Scaler not found. Please copy libswscale from FFMpeg"
> > > +fi
> > > +echocheck "New software scaler"
> > > +_new_swscaler=no
> > > +cat > $TMPC <<EOF
> > > +#include <stdint.h>
> > > +#include "libswscale/swscale.h"
> > > +#ifndef LIBSWSCALE_BUILD
> > > +#error Old Software Scaler
> > > +#endif
> > > +int main(void) { return 0; }
> > > +EOF
> > > +cc_check -I . && _new_swscaler=yes
> > > +echores "$_new_swscaler"
> 
> I can't make much sense of this check.
Well, you just discovered that my shell skills are not very advanced ;-)
Anyway, the idea behind this code was:
1) Check if swscale is in ./libwscale. If not, complain and die
2) Check if ./libswscale contains the current code, or the "new
version" (that define LIBSWSCALE_BUILD). As I just wrote in another
mail, this check is not really needed; I only used it to print an
informative message telling which version of the software scaler is
compiled.

I think I copied these checks from somewhere in the mplayer configure
script, and they seemed to work as expected. But I do not really know
this configure stuff very well: if you say the checks are wrong, I
believe you.

>  Please look at the ones for
> libav* and libpostproc and copy + paste them with the proper
> modifications.
Well, I think the checks can be removed:
- If the patch is applied when postproc is moved to ffmpeg/libswscale,
and and svn:external property is used to tell svn to checkout such
directory in mplayer/libswscale too, then the first check is useless
(libswscale will always be there).
- The second check was not really used, so it can be removed.

>   The current revision of this patch is rejected.
Ok, I'll redo the patch removing the configure and Makefile chunks.
Sorry for posting that unacceptable code, but when I sent the patch to
mplayer-dev-eng asking for comments I did not receive any feedback about
it.

			Thanks,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !