[Ffmpeg-devel] truncated audio output

[Michael Niedermayer]

Hi

On Mon, Jun 19, 2006 at 04:12:00PM -0400, Justin Ruggles wrote:
> M?ns Rullg?rd wrote:
> > Michael Niedermayer said:
> > 
> >>Hi
> >>
> >>On Mon, Jun 19, 2006 at 10:01:36AM +0100, M?ns Rullg?rd wrote:
> >>
> >>>Michael Niedermayer said:
> >>>
> >>>>Hi
> >>>>
> >>>>On Mon, Jun 19, 2006 at 12:11:26AM -0400, Justin Ruggles wrote:
> >>>>
> >>>>>After re-reading my post, I figured that my idea might be better
> >>>>>explained by a patch.  Here is what it would look like if I modified the
> >>>>>pcm encoder to use my suggestion instead of frame_size=1, which is what
> >>>>>is used currently.
> >>>>
> >>>>i agree that a CODEC_CAP_VAR_FRAME_SIZE needs to be added ...
> >>>
> >>>Couldn't a frame_size of 0 be used to signal this?  Permitting a partial
> >>>last frame is also useful with some codecs.
> >>
> >>but what frame size would then be used for the previous frames?
> >>a codec might not support arbitrary large ones or might not allow non fixed
> >>except for the last
> > 
> > 
> > That would require a new flag.
> > 
> > 
> >>if all codecs which support arbitrary small last frames also support
> >>arbitrary large frames anywhere then of coarse frame_size=0 would be
> >>enough and iam fine with that too ...
> > 
> > 
> > That's the case I meant frame_size=0 would be used for.
> > 
> > Whatever solution we pick, it has to be able to handle both partial final
> > frame and true variable frame size.
> > 
> 
> How does this patch look?

a bit big, i would prefer smaller changes, maybe just a change for the
variable sized last frame? that should fix the problem at hand (lossless
encoding) and then a seperate change for the other stuff if you like


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is