[Ffmpeg-devel] Re: [PATCH] free codec extradata

[Baptiste COUDURIER]

Hi

M?ns Rullg?rd wrote:
> Many of the lavf demuxers allocate space in AVCodecContext.extradata,
> but only a few of them free it.  It makes sense to me to free this
> data in av_close_input_file, especially since av_find_stream_info can
> allocate it as well.  The attached patch makes this change.  Did I
> miss something, or is this not the proper way for some reason?

It also makes sense to me. I fully agree.

> The situation is similar with the encoders in lavc.  IMHO anyone who
> allocates memory should be responsible for freeing it, except when it
> can be done some place that is common for all (such as av_close_input_file
> for demuxers).
> 

again, I fully agree.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312