[Ffmpeg-devel] [PATCH] AIX assembler breakage in libavutil/common.h

[Diego Biurrun]

On Fri, Jun 09, 2006 at 09:24:41PM -0500, Derek E. Lewis wrote:
> The AIX assembler does not support local labels, unlike other UNIX
> assemblers and 'gas'.  The inline assembly code in the PowerPC ifdef
> causes the build to fail because of an assembler syntax error.  This
> patch just ifdef's around the offensive code :-)

> --- libavutil/common.h	(revision 5461)
> +++ libavutil/common.h	(working copy)
> @@ -525,7 +525,8 @@
>  }
>  #endif
>  
> -#if defined(ARCH_X86) || defined(ARCH_X86_64) || defined(ARCH_POWERPC)
> +/* AIX 'as' does not support local labels, so we ifdef around it. -- delewis */
> +#if !defined(_AIX) && (defined(ARCH_X86) || defined(ARCH_X86_64) || defined(ARCH_POWERPC))

nit: I'd prefer if you added the new condition at the end, this makes
the diff slightly more readable.

Now what happens if somebody uses gas or some other compatible assembler
on AIX?  I don't think this is the right solution.

Diego