[Ffmpeg-devel] [PATCH] flash screen video codec

[Michael Niedermayer]

Hi

On Wed, May 31, 2006 at 02:46:53PM +0200, Alex Beregszaszi wrote:
> Hi,
> 
> > >>Adopted all this and fixed a bug in temp buffer allocation.
> > >>    
> > >>
> > >
> > >Originally I used the bitstream reader in the code (the comments you
> > >deleted Benjamin), but imho its an overkill and is faster without it.

the bitstream reader is used only for the header and the "header" of each
zlib chunk, so IMO the zlib overhead will exceed any bitreader overhead by
a huge amount


> > >  
> > >
> > Yes, I see that now when I looked through your original code. I remember
> > that I removed it coz it would be faster without the bitreader. But any
> > way is fine with me.
> 
> Not to mention that you need to resync or reinitialize the bitstream
> reader for each block. (ot at least skip large amount)

theres a skip_bits() in there ...


> 
> So am I against the bitstream reader version :)

unless the compiled code is larger or slower by a non trivial amount iam
in favor of the more readable (bitstream reader) version

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is