[Ffmpeg-devel] [PATCH] MXF demuxer improvements

[Michael Niedermayer]

Hi

On Thu, Jul 27, 2006 at 10:54:16PM +0200, Baptiste Coudurier wrote:
[...]
> +            mxf->packages_refs = av_malloc(mxf->packages_count * sizeof(UID));
> +            mxf->packages = av_mallocz(mxf->packages_count * sizeof(*mxf->packages));
> +            url_fskip(pb, 4); /* useless size of objects, always 16 according to specs */
> +            for (i = 0; i < mxf->packages_count; i++)
> +                get_buffer(pb, mxf->packages_refs[i], 16);

why not get_buffer(pb, mxf->packages_refs, mxf->packages_count * sizeof(UID)); ?


[...]

> +static int mxf_read_metadata_track(MXFContext *mxf, KLVPacket *klv)
> +{

this function seems to have been moved around which is a cosmetic change 
and as such should be seperate from functional ones


[...]
> -            get_buffer(pb, desc->essence_container, 16);
> +            get_buffer(pb, descriptor->essence_container_uid, 16);
>              break;
>          case 0x3006:
> -            desc->linked_track_id = get_be32(pb);
> +            descriptor->linked_track_id = get_be32(pb);
>              break;
>          case 0x3201: /* PictureEssenceCoding */
> -            desc->codec_type = CODEC_TYPE_VIDEO;
> -            get_buffer(pb, desc->essence_compression, 16);
> +            get_buffer(pb, descriptor->essence_codec_uid, 16);

ive no objections against the name changes, after all its your demuxer
but please do them in a seperate commit/patch, that keeps svn-log more 
readable (and patches easier to review)


[...]
>  /* SMPTE RP224 http://www.smpte-ra.org/mdd/index.html */
> -static const CodecTag mxf_sound_essence_labels[] = {
> -    { CODEC_ID_PCM_S16LE, 0x01000000 },/* Uncompressed Sound Coding */
> -    { CODEC_ID_PCM_S16LE, 0x017F0000 },/* Uncompressed Sound Coding */
> -    { CODEC_ID_PCM_S16BE, 0x017E0000 },/* Uncompressed Sound Coding Big Endian*/
> -    { CODEC_ID_PCM_ALAW,  0x02030101 },
> -    { CODEC_ID_AC3,       0x02030201 },
> -  //{ CODEC_ID_MP1,       0x02030104 },
> -    { CODEC_ID_MP2,       0x02030105 },/* MP2 or MP3 */
> -  //{ CODEC_ID_MP2,       0x02030106 },/* MPEG-2 Layer 1 */
> -  //{ CODEC_ID_???,       0x0203010C },/* Dolby E */
> -  //{ CODEC_ID_???,       0x02030301 },/* MPEG-2 AAC */
> -    { 0, 0 },
> -};

some of these codec ids seem to have dissapeared in the new code, i assume
they never worked, or why where they removed?


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is