[Ffmpeg-devel] [PATCH] '/nop' illegal for old versions of GAS

[Michael Niedermayer]

Hi

On Mon, Jul 24, 2006 at 11:34:24AM +1000, Nigel Pearson wrote:
> 
> Purpose: Allow simple_idct_mmx.c to compile on Intel OS X/Darwin
> Applies: SVN r5816
> Testing: Since March by various anonymous Wiki users,
>          Myself for a few weeks
> Authors: Sam Hocevar, Nigel Pearson
> 
> 
> Discussion: The IDCT C-source macros in simple_idct_mmx.c
> have a "rounder" argument whose /nop value causes problems:
> 
> cc -O3  -no-cpp-precomp -pipe -force_cpusubtype_ALL -Wno-sign-compare 
> -fomit-frame-pointer -g -Wdeclaration-after-statement -Wall -Wno-switch 
> -mdynamic-no-pic -DHAVE_AV_CONFIG_H -I.. 
> -I/Users/nigel/ffmpeg/libavutil -D_FILE_OFFSET_BITS=64 
> -D_LARGEFILE_SOURCE -D_ISOC9X_SOURCE    -c -o i386/simple_idct_mmx.o 
> i386/simple_idct_mmx.c
> {standard input}:410:Junk character 47(/)
> {standard input}:410:Rest of line ignored. 1st Junk character valued 
> 110 (n).
> ...
> 
> Changing the argument to either #nop or "nop" allows
> compilation on Intel OS X/Darwin (which uses as 1.38).
> The "nop" form is illegal on Linux GAS (e.g. 2.15).

nop is not equivalent, the fact that you tried it scares me ...
not using a preprocessor macro but instead just replacing one well tested
and working variant by a allmost untested variant where you apparently
didnt even read the manual is completely unacceptable

heres what the gas manual says about lines starting with #
---
To be compatible with past assemblers, lines that begin with `#'
have a special interpretation.  Following the `#' should be an absolute
expression (*note Expressions::): the logical line number of the _next_
line.  Then a string (*note Strings: Strings.) is allowed: if present
it is a new logical file name.  The rest of the line, if any, should be
whitespace.
---

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is