[Ffmpeg-devel] Re: [PATCH] Intel Mac MMX/SSE2 support

[Michael Niedermayer]

Hi

On Thu, Jul 20, 2006 at 01:16:48PM +1000, Nigel Pearson wrote:
> 
> 	Hi. I'm Nigel.
> 
> 	I did a lot of the porting of MythTV to the Mac,
> and am thus an indirect user/developer of ffmpeg.
> Sorry to jump in late, but I am anxious to get
> some of this committed to reduce the patching
> burden for Intel MythTV hackers.
> 
> 
> 	Assuming that we are not going to force users to
> upgrade GAS, or Apple to change binary format,
> could we discuss/apply the patch file by file?
> 
> 
> 	Guillaume's reworked patch seems fairly tidy to me.
> Apart from one missing line of context at the end,
> it applies cleanly to SVN r5799, and with the configure
> workaround (no memalign), builds and almost works.
> 
> (make test fails ...

1. nothing almost working will be applied, it has to be fully working
2. fix your mailer, most people hate having to search for mails with
   similar subjects to find the patch you are talking about
3. ive said many times that replacing balign <-> p2align will not happen
   this must be done with a macro and that macro must not be in a x86
   specific file
4. indepenant changes must be in seperate patches (the align change is 
   such a thing)

no mac-intel patches passed these trivial criteria IIRC

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is