[Ffmpeg-devel] Re: [PATCH] MXF demuxer

[Baptiste Coudurier]

Hi

Michael Niedermayer wrote:
> Hi
> 
> On Tue, Jul 18, 2006 at 01:32:34AM +0200, Baptiste Coudurier wrote:
> [...]
>>> [...]
>>>
>>> imagine when you click on a save button to save several hours work which
>>> you did in a video editor, webpage with a little gif anim or similar
>>> and suddenly the shiny GUI dissapears and the commandline presents you
>>> with a "assert(desc->sample_rate.num % desc->sample_rate.den == 0) failed"
>>> and all your hard work is gone ...
>>>
>> Hehe. I fully undertand the point here, but how this is comparable to
>> the asserts in mov.c checking the time_rate ?
> 
> time_rate is calculated as the gcd of all sample "durations" so the asserts
> should never fail 
> 
> [...]
> 

Indeed. Here is a new version. Btw do you have any idea to tread those
16 bytes UID keys easier ?

Also Im thinking about the need of some sort of "pattern" to check
against those key like "0x06... 0xXX, 0xXX" that way all hardcoded keys
would be 16 bytes.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mxf_demuxer.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060719/9ae06e8e/attachment.txt>