[Ffmpeg-devel] Re: [PATCH] GXF muxer

Baptiste Coudurier baptiste.coudurier
Wed Jul 19 11:41:20 CEST 2006


Michael Niedermayer wrote:
> Hi
> On Tue, Jul 18, 2006 at 01:43:47PM +0200, Baptiste Coudurier wrote:
>> Hi
>> Michael Niedermayer wrote:
>>> [...]
>>> except these ive no objections, feel free to commit it ...
>> Ok I changed it as you suggested. I added dts code. Are dts correct for
>> audio packets ? Im afraid the division will not be exact.
> i dont know the gxf spec so i cant comment on what is correct for gxf
> but at least for anything but 16bit raw audio it looks very wrong

In GXF specs, each packet (compressed or not must contain 32768
samples). GXF can contain ac3 also, but atm I only allow PCM_S16LE mono

>> I also notice first packet has dts -1 when encoding to mpeg2. Am I doing
>> something wrong as usual ?
> no, thats a feature (or bug), whichever way you want to see it

Ah, I'll investigate this further.

> btw, please commit this, and send patches relative to what will then be
> in svn as that would simplify reviewing ...


Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312

More information about the ffmpeg-devel mailing list