[Ffmpeg-devel] libtheora brokenness in lavc

[Rich Felker]

On Sun, Jul 16, 2006 at 07:40:48PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > Hi
> >
> > On Sun, Jul 16, 2006 at 01:48:08PM -0400, Rich Felker wrote:
> >> i noticed today while talking on #ffmpeg that lavc has a
> >> libtheora-based theora encoder and decoder. when this module is
> >
> > encoder? where?
> 
> Nowhere.

i thought i saw the encoder in allcodecs.c but i'm probably on crack..

> >> enabled, the native code is disabled, which has the extremely
> >> unfortunate side-effect of alterring the expected and generated
> >> bitstream format. the codec init headers are passed in-band as frames
> >> instead of being stored in and read from extradata.
> 
> Hmm, my copy of oggtheora.c uses extradata just like vp3.c.

yes, i dunno wtf i looked at. please disregard my nonsense report.

> >> imo oggtheora.c should just be removed, but if this is not acceptable,
> >> the current situation is a bug and the header conversion stuff needs
> >> to be added to it..
> >
> > i vote for removing libtheora support theres no sense in it, only use
> > would be debuging our decoder but then there are other tools like
> > mplayer which can be used and as you say our decoder is disabled if
> > libtheora is enabled so its not that usefull for debuging either
> 
> I don't mind removing it, but does the native decoder now support
> theora fully?  I know it used to be incomplete.

i'm told it's not complete but i dunno.

rich