[Ffmpeg-devel] [PATCH] Cygwin vhook, always static avformat

[Víctor Paesa]

Hi,

The next attempt on the vhook, shared lib Cygwin patches, attached.

Diego wrote:
>> --- ffmpeg-old/configure        2006-07-14 18:19:20.000000000 +0200
>> +++ ffmpeg/configure        2006-07-14 20:32:42.437500000 +0200
>> @@ -331,6 +331,7 @@
>>  incdir='${prefix}/include/ffmpeg'
>>  mandir='${prefix}/man'
>>  bindir='${prefix}/bin'
>> +shlibdir='$libdir'
>
>Tried the patch? ;-)
Correct guess: I tried "make", it worked and I was happy, but I
didn't tried "make install", that doesn't work. Shamefully sorry ...


>IMO you should also add configure parameters for setting shlibdir etc.
>
I thought about it, but that would exceed the stated goal of allowing
shared libraries under Cygwin, I will add them via another patch.


Mans wrote:
>> diff -Naur ffmpeg-old/configure ffmpeg/configure
>> --- ffmpeg-old/configure        2006-07-14 18:19:20.000000000 +0200
>> +++ ffmpeg/configure        2006-07-14 20:32:42.437500000 +0200
>> @@ -331,6 +331,7 @@
>>  incdir='${prefix}/include/ffmpeg'
>>  mandir='${prefix}/man'
>>  bindir='${prefix}/bin'
>> +shlibdir='$libdir'
>>  cross_prefix=""
>>  cross_compile="no"
>>  cc="gcc"
>> @@ -585,6 +586,7 @@
>>  mingw32="yes"
>>  ;;
>>  CYGWIN*)
>> +shlibdir='$bindir'
>>  v4l="no"
>>  v4l2="no"
>>  audio_oss="yes"
>
>Should be shlibdir='${whatever}'
>
Absolutely true until SVN-5754.
At SVN-5754, shlibdir='${PREFIX}/lib' or shlibdir='${PREFIX}/bin'


>> @@ -1557,6 +1564,7 @@
>>  echo "libdir=\$(DESTDIR)$libdir" >> config.mak
>>  echo "incdir=\$(DESTDIR)$incdir" >> config.mak
>>  echo "bindir=\$(DESTDIR)$bindir" >> config.mak
>> +echo "shlibdir=$shlibdir" >> config.mak
>
>shlibdir=\$(DESTDIR)$shlibdir
>
Not until SVN-5754, because $libdir/$bindir in config.mak already
contained $(DESTDIR).
But you're a good forseer :-) , because at SVN-5754, the way is
certainly shlibdir=\$(DESTDIR)$shlibdir


>>Wow, an almost clean patch.  Not even anything worthy of a good flame.
Well, we Cygwin people are bound to be ethernally flamed, either by
Unix or by Windows people, both find ways to fire up the torchs :-)

Regards,
V?ctor Paesa
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.cygwin.vhook.6.patch
Type: application/octet-stream
Size: 1642 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060716/b9ceff9c/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.cygwin.sharedlibs.2.patch
Type: application/octet-stream
Size: 2380 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060716/b9ceff9c/attachment-0001.obj>