[Ffmpeg-devel] [PATCH] conditionally build parts of lavc

Måns Rullgård mru
Sat Jul 15 21:28:39 CEST 2006


Diego Biurrun <diego at biurrun.de> writes:

> On Sat, Jul 15, 2006 at 05:45:59PM +0100, M?ns Rullg?rd wrote:
>> Diego Biurrun <diego at biurrun.de> writes:
>> 
>> > On Sat, Jul 15, 2006 at 03:42:57PM +0100, M?ns Rullg?rd wrote:
>> >> 
>> >> Here's a patch that lets parts of lavc and lavf be built only if some
>> >> enabled codec needs them.  The dependencies may need to be adjusted a
>> >> little, and some code could be moved between files to make it work
>> >> better, but this should be good for an initial review.
>> >> 
>> >> Please test and comment.
>> >> 
>> >> --- configure	(revision 5752)
>> >> +++ configure	(working copy)
>> >> @@ -2094,10 +2095,16 @@
>> >>    echo "AMR_CFLAGS=-DIF2=1" >> config.mak
>> >>  fi
>> >>  
>> >> +for codec in $DECODER_LIST $ENCODER_LIST $PARSER_LIST $DEMUXER_LIST $MUXER_LIST; do
>> >> -for codec in $DECODER_LIST $ENCODER_LIST $PARSER_LIST $DEMUXER_LIST $MUXER_LIST; do
>> >
>> > Hmm, cosmetic change?
>> 
>> Stupid diff.  Can you see *any* difference in those two lines?
>
> I thought it might be trailing whitespace, which my mailer does not
> print..

Doesn't your commit script prevent that?

>> >> --- confdeps.mak	(revision 0)
>> >> +++ confdeps.mak	(revision 0)
>> >> @@ -0,0 +1,351 @@
>> >> +or = $(if $(findstring $(1),$(foreach v,$(2),$($(v)))),echo $@,false)
>> >
>> > That's a nice one.  Why something like OR is not directly available in
>> > Makefiles escapes me...
>> >
>> >> +CONFIG_AMR_NB_DECODER:
>> >> +	@$(call or,yes,CONFIG_AMR_NB CONFIG_AMR_NB_FIXED)
>> >> +CONFIG_AMR_NB_ENCODER:
>> >> +	@$(call or,yes,CONFIG_AMR_NB CONFIG_AMR_NB_FIXED)
>> >
>> > I assume this could also be solved in configure by doing something along
>> > the lines of setting
>> >
>> > CONFIG_AMR_NB and CONFIG_AMR_NB_FIXED
>> > or
>> > CONFIG_AMR_NB and CONFIG_AMR_NB_FLOAT
>> 
>> That's an option.  It should be done separately though.
>
> Yes.
>
> But since we're running a build system cleanup competition anyway.. ;-)

Oh, so that's what this is...

-- 
M?ns Rullg?rd
mru at inprovide.com




More information about the ffmpeg-devel mailing list