[Ffmpeg-devel] [PATCH] Cygwin vhook, always static avformat

[Måns Rullgård]

Diego Biurrun <diego at biurrun.de> writes:

>> --- ffmpeg-old/vhook/Makefile	2006-07-12 17:55:48.000000000 +0200
>> +++ ffmpeg/vhook/Makefile	2006-07-13 18:07:12.968750000 +0200
>> @@ -5,6 +5,13 @@
>>  CFLAGS=-fPIC $(SHCFLAGS) -I.. -I$(SRC_PATH) -I$(SRC_PATH)/libavformat \
>>         -I$(SRC_PATH)/libavcodec -I$(SRC_PATH)/libavutil -DHAVE_AV_CONFIG_H
>>  
>> +ifeq ($(TARGET_OS),CYGWIN)
>> +    EXTRALIBS := -Wl,--no-whole-archive \
>> +                 -L../libavformat -lavformat$(BUILDSUF) \
>> +                 -L../libavcodec  -lavcodec$(BUILDSUF)  \
>> +                 -L../libavutil   -lavutil$(BUILDSUF) $(EXTRALIBS)
>> +endif
>> +
>>  #FIXME: This needs to be in configure/config.mak
>>  ifeq ($(CONFIG_DARWIN),yes)
>>  	SHFLAGS = -dynamiclib -Wl,-single_module -flat_namespace \
>
> This is hackish, then again, we already have this other FIXME for Darwin
> there.  The vhook build needs to be overhauled, but this is not
> necessarily for you to solve..

I'd tend to agree there.

>> @@ -14,13 +21,13 @@
>>  
>>  ifeq ($(HAVE_IMLIB2),yes)
>>      HOOKS += imlib2$(SLIBSUF)
>> -    LDFLAGS += -lImlib2
>> +    EXTRALIBS += -lImlib2
>>  endif
>
> Remind me why this is necessary...

With some linkers, objects and -l options need to be in dependency
order, and other linker flags should be at the start of the argument
list.  LDFLAGS is passed at the start and EXTRALIBS at the end, so -l
options go in EXTRALIBS.

-- 
M?ns Rullg?rd
mru at inprovide.com