[Ffmpeg-devel] [PATCH] enable/disable (de)muxers

[Diego Biurrun]

On Sun, Jul 09, 2006 at 11:35:21PM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Sun, Jul 09, 2006 at 11:10:40PM +0100, M?ns Rullg?rd wrote:
> >> M?ns Rullg?rd <mru at inprovide.com> writes:
> >> 
> >> > OK, here's the initial patch for review.  I'd like to have someone
> >> > else cast an eye on it before I commit, just in case I did something
> >> > really silly.
> >> 
> >> Hmm... already a flaw found.  Updated patch attached.
> >> 
> >> --- ffplay.c	(revision 5695)
> >> +++ ffplay.c	(working copy)
> >> @@ -1790,7 +1790,7 @@
> >>  #ifdef CONFIG_NETWORK
> >> -    use_play = (ic->iformat == &rtsp_demux);
> >> +    use_play = (ic->iformat == &rtsp_demuxer);
> >>  #else
> >> @@ -1884,7 +1884,7 @@
> >>          }
> >> -        if (is->paused && ic->iformat == &rtsp_demux) {
> >> +        if (is->paused && ic->iformat == &rtsp_demuxer) {
> >>              /* wait 10 ms to avoid trying to get another packet */
> >
> > Here and below I'd prefer to see all those (semi-cosmetic) renaming
> > operations done in a separate patch/commit, this will shrink this patch
> > considerably and make it easier to review.
> 
> I suppose I could first do all the renames, keeping the structure.
> Such a patch would have the same size as this one (more or less).
> That would then be followed by another patch to remove the 'static' in
> the definitions, making for another patch of about the same size.

I was expecting it to be considerably smaller, after a closer reading of
the patch I may be wrong and the saving might not be so big after all..

Diego