[Ffmpeg-devel] [PATCH] move utf8 writing to libavutil

Justin Ruggles jruggle
Sun Jul 9 03:12:11 CEST 2006

M?ns Rullg?rd wrote:
> Justin Ruggles <jruggle at earthlink.net> writes:
>>+#define PUT_UTF8(val)\
>>+    do {\
>>+    if(val < 0x80){\
> This could do with a little indentation.  Sure, it's not a big deal
> being a macro definition and all.  It's only that bad indentation is
> one of those things I just can't stand...

Yeah, I debated both ways. I figured that if the do{}while(0) was added
to GET_UTF8, indenting the whole block would be against the cosmetic
changes policy...and I wanted the 2 macros to match... If the patch is
okay otherwise, I don't have any strong feelings one way or the other.


More information about the ffmpeg-devel mailing list