[Ffmpeg-devel] swscale patch

[Luca Abeni]

Hi Michael,
On Tue, 2006-07-04 at 14:39 +0200, Michael Niedermayer wrote:
[...]
> > Index: mplayer/libswscale/swsutil.h
[...]
> why is this not put in swscale_internal.h ?
> [...]
> > Index: mplayer/libswscale/swscaler_glue.c
[...]
> why is this not put in swscale.c ?
Ok; I'll move that code to swscale_internal.h and swscale.c, and I'll
remove swsutil.h and swscaler_glue.c

> [...]
> > Index: mplayer/mplayer.c
[...]
> > Index: mplayer/mencoder.c
[...]
> that code duplication is unacceptable
This is the code duplication that I tried to avoid by introducing
sws_interface.c and sws_init() in my previous patch, but you did not
like such double level of initialization (if I understand well).

So, the only remaining solution that I can think about is to introduce a
sws_interface.c file containing the definitions of my_alloc() and
my_log(), and to put
sws_global_init(my_alloc, free, my_log);
in mplayer.c and mencoder.c. I do not like this solution much (because
in this way my_alloc() and my_log() cannot be static, and I will have to
create an additional header with their prototypes - or put the
prototypes directly in mplayer.c and mencoder.c). But if you think it's
better, I'll do it. Let me know.


			Thanks again,
				Luca
-- 
_____________________________________________________________________________
Copy this in your signature, if you think it is important:
                               N O    W A R ! ! !