[Ffmpeg-devel] [PATCH] Chinese AVS video decoder

Stefan Gehrer stefan.gehrer
Sun Jul 2 18:05:01 CEST 2006

Von: Michael Niedermayer 

> i didnt suggest to change the prediction functions, my suggestion was just
> to not copy the contents of left/top_border* into yet another buffer but
> instead pass a pointer to them ...

Oh, I see. I will look into that.

> thats ok, but making all functions in cavsdsp non static and initalizing
> DSPContext with them in dsputil.c is messy, they should stay static and
> the init should be done in a function in cavsdsp.c
> furthermore your patch mixes cosmetical changes (variable renamings,
> comment
> changes) and functional changes, such patches are not acceptable
> ive commited the changes to mpeg12* and avcodec.h as they are independant
> of the rest and they didnt mix cosmetic & functional changes

How is this for the functional part now? Eliminates cavsdsp.h and
leaves only five functions non-static in dsputil.c, all prefixed with ff_.

Stefan Gehrer

"Feel free" ? 10 GB Mailbox, 100 FreeSMS/Monat ...
Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cavsdiff4
Type: application/octet-stream
Size: 22410 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060702/f70a6186/attachment.obj>

More information about the ffmpeg-devel mailing list