[Ffmpeg-devel] [PATCH] part 10 - portability fixes (ILP32 vs LP64)

[Michael Niedermayer]

Hi

On Tue, Jan 31, 2006 at 12:06:17AM +0100, Stephane van Hardeveld wrote:
> Hi list,
> 
> Lately I tried to decode an ADPCM 32 kbit/s (g.726) stream, coming from 
> a device with an ARM processor. The sound was recognizable, but awful.

submit sample g726 file


> 
> I checked google for a definition of the standard, and it seems g.726 
> proscribes de bits have to be delivered in little endian. I also found 
> an implementation on the net (http://www.tixy.clara.net/source/#G726).
> 
> I checked the g726.c file, and I believe the g726_decode_frame does not 
> take the endianness into account. I changed it (see below) and it works 
> for me now, but I am not sure if this is the right way to do it. Maybe I 
> should create a seperate input reader which solves the endianness on the 
> fly?

your code isnt going to work with anything but 4bit/sample

[...]

-- 
Michael