[Ffmpeg-devel] [PATCH] aiff/aiff-c format encoder and decoder

[Michael Niedermayer]

Hi

On Mon, Jan 30, 2006 at 05:52:21PM -0500, Patrick Guimond wrote:
> Michael Niedermayer wrote:
> >
> >the uint8_t buffer is ok, but i think the code should use ldexp/frexp like 
> >the
> >others
> [...]
> >
> >segfault due to 64bit alignment on some architecture
> [...]
> >
> >IIRC NAN/INFINITY are not defined everywere, 0.0/0.0 is used by the others
> >so thats probably safer
> [...]
> >breaks if the system doesnt use IEEE doubles or if the int and double byte 
> >ordering differs
> 
> 
> Considered those issues in this patch, any comments welcome

[...]

> +/* IEEE 80 bits extended float */
> +typedef struct AVExtFloat  {
> +    uint8_t exponent[2];
> +    uint8_t mantissa[8];
> +} __attribute__((packed)) AVExtFloat ;

without the attribute packed (IMHO unneeded and will break on non gcc) the
patch looks ok and can be applied assuming it compiles and regression tests
still pass

speaking of regresson tests, AIFF should get one too after this is applied

[...]

-- 
Michael