[Ffmpeg-devel] [PATCH] register_protocol

Michel Bardiaux mbardiaux
Mon Jan 30 11:28:43 CET 2006


Michael Niedermayer wrote:
> Hi
> 
> On Mon, Jan 30, 2006 at 10:40:48AM +0100, Michel Bardiaux wrote:
> 
>>Michael Niedermayer wrote:
>>
>>>Hi
>>>
>>>On Tue, Jan 03, 2006 at 12:00:26PM +0100, Michel Bardiaux wrote:
>>>
>>>
>>>>The current implementation has several problems:
>>>>
>>>>(1) Call av_register_all, the register one of yours, then
>>>>av_register_all again: yours is lost... Worse: register yours, call
>>>>av_register_all, register yours again, you get... only yours.
>>>
>>>
>>>if(p == protocol)
>>>   return -1;
>>>
>>>
>>>
>>>
>>>>(2) Relies on a linked list that actually resides in klientland.
>>>
>>>
>>>and yours is bloated and leaks :)
>>
>>Could you point out the leak?
> 
> 
> av_malloc() ... what else? load lib, register something, unload ...
> it should be av_malloc_static()

Of course, please hand over the flatiron :-)

Now, what about my defense against the accusation of 'bloat'?

> 
> [...]


-- 
Michel Bardiaux
R&D Director
T +32 [0] 2 790 29 41
F +32 [0] 2 790 29 02
E mailto:mbardiaux at mediaxim.be

Mediaxim NV/SA
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
http://www.mediaxim.com/





More information about the ffmpeg-devel mailing list