[Ffmpeg-devel] [PATCH] WinCE support (via gcc cross-compiling)

[Diego Biurrun]

On Sun, Jan 22, 2006 at 09:01:25PM +0000, Gildas Bazin wrote:
> On Sunday 22 January 2006 18:30, Diego Biurrun wrote:
> > On Sun, Jan 22, 2006 at 08:19:16PM +0100, Aurelien Jacobs wrote:
> > > On Sun, 22 Jan 2006 18:28:16 +0100
> > > Diego Biurrun <diego at biurrun.de> wrote:
> > > > 
> > > > Maybe I'm not being clear..
> > > > 
> > > > You have added
> > > > 
> > > >   +#if defined(CONFIG_WINCE)
> > > >   +#elif defined(CONFIG_WIN32)
> > > > 
> > > > Thus effectively making #if defined(CONFIG_WINCE) into a noop since
> > > > nothing comes after it before the #elif ...
> > > 
> > > What you didn't noticed is that CONFIG_WIN32 is now in a #elif section,
> > > so this CONFIG_WIN32 code is now no more parsed when CONFIG_WINCE is 
> defined.
> > > So yes, this hunk seem to be useful, despite being quite ugly.
> > > Something like this would probably be better :
> > >   #if defined(CONFIG_WIN32) && !defined(CONFIG_WINCE)
> > 
> > Right, I had overlooked that..
> > 
> > Patch applied with the suggested change.
> > 
> 
> Except that now the WINCE case will fallback to the "#else" section, which 
> is not wanted either.

OK, I've switched back to your initial suggestion and added a comment to
that effect to the code.

> Thanks for applying the patch Diego.

You're welcome.

Diego